Re: narwhal and PGDLLIMPORT

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Hiroshi Inoue <inoue@tpf.co.jp>

Cc: Andrew Dunstan <andrew@dunslane.net>, Craig Ringer <craig@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@2ndquadrant.com>, Amit Kapila <amit.kapila16@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2014-02-14T01:11:10Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

MinGW: Link with shell32.dll instead of shfolder.dll.
- 53566fc0940c 9.5.0 cited
Centralize getopt-related declarations in a new header file pg_getopt.h.
- 60ff2fdd9970 9.4.0 cited
Get rid of use of dlltool in Mingw builds.
- 846e91e0223c 9.4.0 cited
Export a few more symbols required for test_shm_mq module.
- 7d7eee8bb702 9.4.0 cited
Export set_latch_on_sigusr1 symbol for Windows.
- 708c529c7fde 9.4.0 cited
Use SHGetFolderPath instead of SHGetSpecialFolderPath to find the
- 889f03812916 8.1.0 cited

Hiroshi Inoue <inoue@tpf.co.jp> writes:
> Rebuild with --disable-auto-import causes errors in contrib on
> both machines. Errors occur in pg_buffercache, pg_stat_statements,
>  postgres_fdw and test_shm_mq.

Yeah, that's the idea: we want to get the same failures as on MSVC.
I'm going to put in PGDLLIMPORT macros to fix these cases, but I'm
waiting for verification that Cygwin also sees the problem before
making it go away.

brolga unfortunately seems to have been AWOL for the past day and
a half.  Andrew, could you give it a kick?

			regards, tom lane