Re: log bind parameter values on error

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, Alexey Bashtanov <bashtanov@imap.cc>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-12-09T20:15:22Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2019-Dec-09, Tom Lane wrote:
>> Good point: if we make a separate source file then we don't have
>> to solve any of the code-movement issues till somebody wants this
>> functionality in frontend.  But we should expect that that day might
>> come eventually, so I don't much like "stringinfo_server.c" as the
>> file name.  It'll look pretty silly once we start compiling it for
>> frontend.  Perhaps "appendquoted.c" or some such?

> Okay, so here are two patches.  I had already used the name
> stringinfo_mb.c, so that's what's v19.  (I'm fine with renaming it to
> appendquoted.c but we might gain other such functions in the future.
> Other opinions?)

"stringinfo_mb.c" is fine with me.

			regards, tom lane



Commits

  1. Emit parameter values during query bind/execute errors

  2. Add backend-only appendStringInfoStringQuoted