Re: Explicit NULL dereference (src/backend/utils/adt/ruleutils.c)
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: ranier.vf@gmail.com, pgsql-hackers@lists.postgresql.org
Date: 2020-11-02T02:05:29Z
Lists: pgsql-hackers
Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes: > We cannot reach there with ev_action == NULL since it comes from a > non-nullable column. Since most of the other columns has an assertion > that !isnull, I think we should do the same thing for ev_action (and > ev_qual). SPI_getvalue() returns C-NULL for SQL-NULL (or for some > other unexpected situations.). Isn't the comment just above there wrong? /* these could be nulls */ I wonder just when that became outdated. regards, tom lane
Commits
-
Remove special checks for pg_rewrite.ev_qual and ev_action being NULL.
- e1339bfc7a2f 14.0 landed