Horton

Re: pg_checksums: Reorder headers in alphabetical order

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Nathan Bossart <nathandbossart@gmail.com>, Michael Banck <mbanck@gmx.net>
Cc: pgsql-hackers@postgresql.org
Date: 2024-09-21T02:55:53Z
Lists: pgsql-hackers 

On 2024/09/21 5:20, Nathan Bossart wrote:
> On Fri, Sep 20, 2024 at 01:56:16PM -0500, Nathan Bossart wrote:
>> On Fri, Sep 20, 2024 at 07:20:15PM +0200, Michael Banck wrote:
>>> I noticed two headers are not in alphabetical order in pg_checkums.c,
>>> patch attached.
>>
>> This appears to be commit 280e5f1's fault.  Will fix.
> 
> Committed, thanks!

I don’t have any objections to this commit, but I’d like to confirm
whether we really want to proactively reorder #include directives,
even for standard C library headers. I’m asking because I know there are
several source files, like xlog.c and syslogger.c, where such #include
directives aren't in alphabetical order. I understand we usually reorder
#include directives for PostgreSQL header files, though.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. Alphabetize #include directives in pg_checksums.c.

  2. Add progress reporting to pg_checksums