Re: pgsql: Add function to import operating system collations
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
Date: 2017-01-18T18:52:31Z
Lists: pgsql-hackers
On 1/18/17 1:46 PM, Tom Lane wrote: > I wrote: >> The previous coding applied a sort so as not to depend on what >> order "locale -a" had returned things in, and I think we need >> to retain that. At the very least, all the normalized names >> need to be saved up and entered in a second pass. > > Actually, it seems like doing precisely that should be enough to fix > it. The original names shouldn't have any dups, and if we generate > dup names by stripping, those will be for different encodings so it's > OK. I've pushed a fix based on that. Yeah, I was just about to write the exact same code. Looks good, thanks. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Avoid conflicts with collation aliases generated by stripping.
- 0333a7340054 10.0 landed
-
Add function to import operating system collations
- aa17c06fb585 10.0 cited
-
Remove dead code in bootstrap
- 193a7d791ebe 10.0 cited