Horton

Re: pg_rewind copies

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: David Steele <david@pgmasters.net>, Cary Huang <cary.huang@highgo.ca>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-04-01T11:46:19Z
Lists: pgsql-hackers 
> On 1 Apr 2022, at 12:46, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

>> +	if (len >= sizeof(dstpath))
>> +		pg_fatal("filepath buffer too small");	/* shouldn't happen */
> 
> Makes sense. I would remove the "shouldn't happen"; it's not very hard to make it happen, you just need a very long target datadir path. And rephrase the error message as "datadir path too long".

Right, good point.

> One typo in the commit message: s/update/updates/.

Will fix.

--
Daniel Gustafsson		https://vmware.com/

Commits

  1. pg_rewind: Fetch small files according to new size.