Horton

Re: Simplifying our Trap/Assert infrastructure

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2022-10-28T07:36:23Z
Lists: pgsql-hackers 
On 27.10.22 09:23, Michael Paquier wrote:
> Agreed, even if extensions could use these, it looks like any
> out-of-core code using what's removed here would also gain in clarity.
> This is logically fine (except for an indentation blip in
> miscadmin.h?), so I have marked this entry as ready for committer.

committed

> Side note, rather unrelated to what's proposed here: would it be worth
> extending AssertPointerAlignment() for the frontend code?

Would there be a use for that?  It's currently only used in the atomics 
code.

Commits

  1. Make AssertPointerAlignment available to frontend code

  2. Remove AssertArg and AssertState

  3. Simplify our Assert infrastructure a little.