Horton

Re: Add pg_file_sync() to adminpack

Artur Zakirov <zaartur@gmail.com>

View thread View on postgr.es
From: Arthur Zakirov <zaartur@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Robert Haas <robertmhaas@gmail.com>, Atsushi Torikoshi <atorik@gmail.com>, Fujii Masao <masao.fujii@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-01-24T06:38:11Z
Lists: pgsql-hackers 
On 2020/01/24 14:56, Michael Paquier wrote:
> On Fri, Jan 24, 2020 at 01:28:29PM +0900, Arthur Zakirov wrote:
>> It is compiled and passes the tests. There is the documentation and it is
>> built too without an error.
>>
>> It seems that consensus about the returned type was reached and I marked the
>> patch as "Ready for Commiter".
> 
> +       fsync_fname_ext(filename, S_ISDIR(fst.st_mode), false, ERROR);
> One comment here: should we warn better users in the docs that a fsync
> failule will not trigger a PANIC here?  Here, fsync failure on heap
> file => ERROR => potential data corruption.

Ah, true. It is possible to add couple sentences that pg_file_sync() 
doesn't depend on data_sync_retry GUC and doesn't raise a PANIC even for 
database files.

-- 
Arthur

Commits

  1. Add pg_file_sync() to adminpack extension.