Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Michael Paquier <michael@paquier.xyz>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Tobias Bussmann <t.bussmann@gmx.net>, Mark Guertin <markguertin@gmail.com>, pgsql-bugs@lists.postgresql.org

Date: 2023-04-20T08:50:27Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Skip .DS_Store files in server side utils
- d3fdfdcd1c7f 13.15 landed
- c1fc502f595b 17.0 landed
- aeee173d2292 14.12 landed
- 76bb6dd2e56c 12.19 landed
- 29f00523808a 15.7 landed
- 103235888d9e 16.3 landed

Attachments

skip_hidden_files.diff (application/octet-stream) patch

> On 20 Apr 2023, at 02:15, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Wed, Apr 19, 2023 at 02:15:51PM -0400, Tom Lane wrote:
>> Yeah.  I wonder if we ought to do something more general, and
>> ignore all files whose names start with ".".
> 
> Indeed.  I don't see any point is adding hidden files for the
> checksum, rewind and base backup lists, so we could just make it a
> hardcoded rule.  That's currently what we do for configuration files
> when using include_dir for postgresql.conf (as well as hba and ident
> files in 16~).

The attached trivial diff skips hidden files for pg_basebackup and pg_checksums
as part of the checks already performed by these tools for skipping other
files.  Skimming other callsites of ReadDir and readdir I didn't see any others
which could benefit from skipping hidden files.

--
Daniel Gustafsson