Re: s/pg_attribute_always_inline/pg_always_inline/?
Peter Eisentraut <peter@eisentraut.org>
From: Peter Eisentraut <peter@eisentraut.org>
To: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2026-04-09T00:00:37Z
Lists: pgsql-hackers
On 08.04.26 23:09, Andres Freund wrote: > Hi, > > When reviewing the index prefetching patch I got a bit dismayed at how long > pg_attribute_always_inline is due to the way it triggers pgindent to format > stuff. > > I propose that we remove the _attribute_ part of the name. > > Given that it is implemented for compilers that don't use the > __attribute__((always_inline)) spelling, so the shorter name seems better > anyway. Yes, and the existing name is also kind of wrong even on GCC because the macro does not expand to only an attribute but also includes the "inline".