Re: Speedup twophase transactions

David Steele <david@pgmasters.net>

From: David Steele <david@pgmasters.net>

To: Michael Paquier <michael.paquier@gmail.com>, Jesper Pedersen <jesper.pedersen@redhat.com>

Cc: Stas Kelvich <s.kelvich@postgrespro.ru>, Simon Riggs <simon@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2016-03-29T15:04:46Z

Lists: pgsql-hackers

Hi Stas,

On 3/22/16 9:20 AM, Michael Paquier wrote:

> Not taking ProcArrayLock here?
>
> The comment at the top of XlogReadTwoPhaseData is incorrect.
>
> RecoverPreparedFromXLOG and RecoverPreparedFromFiles have a lot of
> code in common, having this duplication is not good, and you could
> simplify your patch.

It looks like you should post a new patch or respond to Michael's 
comments.  Marked as "waiting on author".

Thanks,
-- 
-David
david@pgmasters.net

Commits

Speedup 2PC recovery by skipping two phase state files in normal path
- 728bd991c3c4 10.0 landed
Add tests for two-phase commit
- 30820982b295 10.0 landed
Improve grammar of message about two-phase state files.
- 38c363adf497 10.0 landed
Speedup 2PC by skipping two phase state files in normal path
- 978b2f65aa12 9.6.0 cited