Horton

Re: PoC: Partial sort

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Peter Geoghegan <pg@heroku.com>, Alexander Korotkov <aekorotkov@gmail.com>
Cc: Andreas Karlsson <andreas@proxel.se>, David Rowley <dgrowleyml@gmail.com>, Marti Raudsepp <marti@juffo.org>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@2ndquadrant.com>, Martijn van Oosterhout <kleptog@svana.org>
Date: 2016-03-29T13:56:30Z
Lists: pgsql-hackers 
Hi Alexander,

On 3/23/16 8:39 PM, Peter Geoghegan wrote:

> This looks like an old change you missed:
>
> - * compare_path_fractional_costs
> + * compare_fractional_path_costs
>
> All in all, this looks significantly better. Thanks for your work on
> this. Sorry for the delay in my response, and that my review was
> relatively rushed, but I'm rather busy at the moment with fighting
> fires.

It looks like a new patch is required before this can be marked "ready 
for committer".  Will you have that ready soon?

Thanks,
-- 
-David
david@pgmasters.net

Commits

  1. Implement Incremental Sort

  2. Improve memory management for external sorts.