Horton

Re: btree_gin and btree_gist for enums

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2016-03-18T14:41:47Z
Lists: pgsql-hackers 

On 03/18/2016 09:54 AM, Robert Haas wrote:
> On Thu, Mar 17, 2016 at 11:21 AM, Andrew Dunstan <andrew@dunslane.net> wrote:
>> On 03/17/2016 06:44 AM, Andrew Dunstan wrote:
>>> Here is a patch to add enum support to btree_gin and btree_gist. I didn't
>>> include distance operations, as I didn't think it terribly important, and
>>> there isn't a simple way to compute it sanely and efficiently, so no KNN
>>> support.
>> This time including the data file for the gist regression tests.
> Are you intending this as a 9.7 submission?  Because it's pretty late for 9.6.
>


I guess so. I would certainly find it hard to argue that it should be in 
9.6 unless there is a consensus on it.

cheers

andrew

Commits

  1. Add btree_gin support for enum types

  2. Add btree_gist support for enum types.

  3. Use CallerFInfoFunctionCall with btree_gist for numeric types

  4. Add a direct function call mechanism using the caller's context.

  5. Add support for EUI-64 MAC addresses as macaddr8

  6. Add an Assert that enum_cmp_internal() gets passed an FmgrInfo pointer.