Horton

Re: Memory leak in pg_stat_statements when qtext file contains invalid encoding

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Lukas Fittl <lukas@fittl.com>, Gaurav Singh <gaurav.singh@yugabyte.com>, pgsql-bugs@lists.postgresql.org
Date: 2026-03-27T09:05:18Z
Lists: pgsql-bugs 
> On 27 Mar 2026, at 09:59, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

> Hmm, perhaps. But there's a simpler, less invasive fix. When that code was written, we didn't have MCXT_ALLOC_HUGE nor MCXT_ALLOC_NO_OOM. Now that we do, we can just use palloc_extended(MCXT_ALLOC_HUGE | MCXT_ALLOC_NO_OOM) instead of raw malloc(). Per attached.

LGTM.

--
Daniel Gustafsson

Commits

  1. Avoid memory leak on error while parsing pg_stat_statements dump file