Re: pure parsers and reentrant scanners

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Peter Eisentraut <peter@eisentraut.org>

Cc: Andreas Karlsson <andreas@proxel.se>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-12-20T01:07:49Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Return yyparse() result not via global variable
- 473a575e0597 18.0 landed
Remove flex version checks
- 0869ea43e9c2 18.0 landed
Drop warning-free support for Flex 2.5.35
- 6fdd5d956343 18.0 landed
plpgsql: pure parser and reentrant scanner
- 7b27f5fd36cb 18.0 landed
flex code modernization: Replace YY_EXTRA_TYPE define with flex option
- b1ef48980ddd 18.0 landed
guc: reentrant scanner
- d663f150b5ed 18.0 landed
jsonpath scanner: reentrant scanner
- 2a7425d7eef9 18.0 landed
syncrep parser: pure parser and reentrant scanner
- db6856c9913f 18.0 landed
replication parser: pure parser and reentrant scanner
- e4a8fb8fefb9 18.0 landed
bootstrap: pure parser and reentrant scanner
- 3e4bacb17100 18.0 landed
Small whitespace improvement
- 399d0f1e11b5 18.0 landed
Prevent redeclaration of typedef yyscan_t
- 382092a0cd2c 18.0 landed
seg: pure parser and reentrant scanner
- 1f0de66ea2a5 18.0 landed
cube: pure parser and reentrant scanner
- 802fe923e3cd 18.0 landed

I noticed that lapwing is bleating about

ccache gcc -std=gnu99 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 -fPIC -fvisibility=hidden -I. -I. -I../../src/include  -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/et  -c -o cubescan.o cubescan.c
cubescan.c:1689:5: warning: no previous prototype for 'cube_yyget_column' [-Wmissing-prototypes]
cubescan.c:1765:6: warning: no previous prototype for 'cube_yyset_column' [-Wmissing-prototypes]

and likewise in segscan.c.  lapwing is using flex 2.5.35, so probably
this is the same bug worked around in parser/scan.l:

/*
 * Work around a bug in flex 2.5.35: it emits a couple of functions that
 * it forgets to emit declarations for.  Since we use -Wmissing-prototypes,
 * this would cause warnings.  Providing our own declarations should be
 * harmless even when the bug gets fixed.
 */
extern int	core_yyget_column(yyscan_t yyscanner);
extern void core_yyset_column(int column_no, yyscan_t yyscanner);

			regards, tom lane