Re:Re: [BUG] Incorrect historic snapshot may be serialized to disk during fast-forwarding

ocean_li_996 <ocean_li_996@163.com>

View thread

From: ocean_li_996 <ocean_li_996@163.com>

To: cca5507 <cca5507@qq.com>

Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-11-23T06:33:14Z

Lists: pgsql-hackers

Attachments

v3-0001-Handle-XLOG_HEAP2_NEW_CID-in-fast-forward.patch (application/octet-stream)

Hi ChangAo,
At 2025-11-23 13:31:49, "cca5507" <cca5507@qq.com> wrote:
>> The patch in attachment is better for me. What do you think?
>
>The v2-0001 LGTM.
>
>A small suggestion:
>
>We should move the 'break' out of the 'if', because we don't want it fall through to XLOG_HEAP2_REWRITE if we are fast-forwarding.



Fair. The patch updated is provided in attachment.


Best regards,
Haiyang Li