Re: Renaming of pg_xlog and pg_clog

David Steele <david@pgmasters.net>

From: David Steele <david@pgmasters.net>
To: "David G. Johnston" <david.g.johnston@gmail.com>, Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>, David Fetter <david@fetter.org>, Bruce Momjian <bruce@momjian.us>, Michael Paquier <michael.paquier@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2016-10-21T08:50:36Z
Lists: pgsql-hackers
On 10/21/16 3:12 AM, David G. Johnston wrote:

> I have no problem continuing keeping with historical precedent ​and
> allowing mnemonic abbreviations in our directory and file names at this
> point.

I'm still in favor of pg_xact.  A search of the 9.6 docs brings up a 
number of hits for "xact": pg_last_xact_replay_timestamp(), 
pg_advisory_xact_lock(), pg_advisory_xact_lock_shared(), 
pg_last_committed_xact(),  pg_prepared_xacts(), etc. There are also 
numerous column names that have "xact" in them.

It's not just an arcane developer term when it shows up in a number of 
our user-facing functions/columns.

-- 
-David
david@pgmasters.net


Commits

  1. Rename "pg_clog" directory to "pg_xact".

  2. Improve error reporting in pg_upgrade's file copying/linking/rewriting.