Horton

Re: Reopen logfile on SIGHUP

Alexander Kuzmenkov <a.kuzmenkov@postgrespro.ru>

View thread View on postgr.es
From: Alexander Kuzmenkov <a.kuzmenkov@postgrespro.ru>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andres@anarazel.de, stark@mit.edu, a.lubennikova@postgrespro.ru, pgsql-hackers@postgresql.org, g.smolkin@postgrespro.ru
Date: 2018-04-25T14:45:45Z
Lists: pgsql-hackers

Attachments

On 04/24/2018 06:09 AM, Kyotaro HORIGUCHI wrote:
>
> It seems that the additional description needs to be meld into
> this at the first place? And some caveat may be needed on failure
> cases.

That's right. I applied your diff and rewrote these paragraphs, adding 
some words about the possible loss of messages and how to fix it. I also 
removed the forgotten declaration of CheckLogrotateSignal from xlog.h. 
The updated patch is attached.

We should probably have a commitfest entry for this, so here it is: 
https://commitfest.postgresql.org/18/1622/

-- 
Alexander Kuzmenkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Implement "pg_ctl logrotate" command