Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Magnus Hagander <magnus@hagander.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
Euler Taveira <euler@eulerto.com>,
chenjq.jy@fujitsu.com,
PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
Julien Rouhaud <rjuju123@gmail.com>
Date: 2021-08-18T13:49:48Z
Lists: pgsql-bugs
> On 18 Aug 2021, at 15:46, Magnus Hagander <magnus@hagander.net> wrote: > > On Wed, Aug 18, 2021 at 3:43 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> >> Daniel Gustafsson <daniel@yesql.se> writes: >>>> On 18 Aug 2021, at 13:44, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote: >>>> I think this both of these things could be deleted and we could get rid of the --quiet option, to simplify all this. >> >>> It simplifies the pg_amcheck code a bit, but it at the same time complicates >>> the tests as they are currently written. Not sure that we want to change that >>> much as this point in the 14 cycle? >> >> It's going to become much harder to change pg_amcheck's user-visible >> behavior once it's shipped in a release. Better to fix it now while >> there are not backwards-compatibility concerns. > > +<several>. Let's just get it done now. I doubt many people have had > the time to integrate it into their scripts and such yet, and since > it's a beta... Since there is consensus for removing --quiet, I’ll propose a patch in a bit for removing it and fixing up the tests. -- Daniel Gustafsson https://vmware.com/
Commits
-
Remove --quiet option from pg_amcheck
- 9a9c8b92018d 15.0 landed
- 92ce7f527960 14.0 landed