Horton

Re: a fast bloat measurement tool (was Re: Measuring relation free space)

Tomas Vondra <tomas.vondra@2ndquadrant.com>

View thread
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Amit Kapila <amit.kapila16@gmail.com>, Abhijit Menon-Sen <ams@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Simon Riggs <simon@2ndquadrant.com>
Date: 2015-04-24T14:35:22Z
Lists: pgsql-hackers 

On 04/24/15 14:58, Amit Kapila wrote:
> On Fri, Apr 24, 2015 at 8:46 AM, Abhijit Menon-Sen <ams@2ndquadrant.com
> <mailto:ams@2ndquadrant.com>> wrote:
>  >
>  > At 2015-04-24 08:35:40 +0530, amit.kapila16@gmail.com
> <mailto:amit.kapila16@gmail.com> wrote:
>  > >
>  > > > Just stick a PG_RETURN_NULL() at the end?
>  > >
>  > > That should also work.
>  >
>  > OK, updated patch attached with just that one change.
>  >
>
> Patch looks good to me, will mark it as Ready for Committer if Tomas
> or anyone else doesn't have more to add in terms of review.

FWIW, I'm OK with the patch as is. Your reviews were spot on.

regards

--
Tomas Vondra                   http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services