Horton

Re: pg_combinebackup --clone doesn't work

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-08-23T12:00:48Z
Lists: pgsql-hackers 
On 30.06.24 20:58, Tomas Vondra wrote:
> I've pushed the first three patches, fixing the headers, adding the
> --copy option and PG_TEST_PG_COMBINEBACKUP_MODE variable.
> 
> I haven't pushed the CI changes, I'm not sure if there's a clear
> consensus on which combination to test. It's something we can tweak
> later, I think.
> 
> FWIW I've added the patch to the 2024-07 commitfest, but mostly to get
> some CI runs (runs on private fork fail with some macos issues unrelated
> to the patch).

This last patch is still pending in the commitfest.  Personally, I think 
it's good to commit as is.

Commits

  1. Add PG_TEST_PG_COMBINEBACKUP_MODE to CI tasks

  2. Add PG_TEST_PG_COMBINEBACKUP_MODE

  3. Add pg_combinebackup --copy option

  4. Add headers needed by pg_combinebackup --clone