Horton

Re: Remove traces of long in dynahash.c

Chao Li <li.evan.chao@gmail.com>

View thread View on postgr.es
From: Chao Li <li.evan.chao@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-08-20T23:43:49Z
Lists: pgsql-hackers 
Hi Michael,

> On Aug 21, 2025, at 07:07, Michael Paquier <michael@paquier.xyz> wrote:
> 
> 
> After sleeping on it, I am not sure what to do with these routines.  I
> don't deny that more refactoring can be done.  However, all that can
> also happen outside the long -> int64 switch I am suggesting.
> 
> Any comments from others?
> --
> Michael


I don’t want to block you. Unless others have the same comment about naming, you can go ahead and move forward.  I agree further refactoring can belong to a separate commit. 

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Commits

  1. Remove dynahash.h

  2. Replace callers of dynahash.h's my_log() by equivalent in pg_bitutils.h

  3. Change dynahash.c and hsearch.h to use int64 instead of long