Re: patch : Allow toast tables to be moved to a different tablespace
Andreas Karlsson <andreas@proxel.se>
From: Andreas Karlsson <andreas@proxel.se>
To: Julien Tachoires <julmon@gmail.com>, Alex Shulgin <ash@commandprompt.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
Jaime Casanova <jaime@2ndquadrant.com>,
Robert Haas <robertmhaas@gmail.com>,
Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2015-03-21T12:56:34Z
Lists: pgsql-hackers
On 03/21/2015 01:19 PM, Julien Tachoires wrote: >> I am confused by your fix. Wouldn't cleaner fix be to use >> tbinfo->reltablespace rather than tbinfo->reltoasttablespace when >> calling ArchiveEntry()? > > Yes, doing this that way is cleaner. Here is a new version including > your fix. Thanks. I am now satisfied with how the patch looks. Thanks for your work. I will mark this as ready for committeer now but not expect any committer to look at it until the commitfest starts. -- Andreas Karlsson