Re: patch : Allow toast tables to be moved to a different tablespace

Andreas Karlsson <andreas@proxel.se>

From: Andreas Karlsson <andreas@proxel.se>

To: Julien Tachoires <julmon@gmail.com>, Alex Shulgin <ash@commandprompt.com>

Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Jaime Casanova <jaime@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2015-03-19T23:33:18Z

Lists: pgsql-hackers

Attachments

set_toast_tablespace_v0.15-fix.patch (text/x-patch) patch v0

On 03/19/2015 04:55 PM, Julien Tachoires wrote:
> On 18/03/2015 19:54, Andreas Karlsson wrote:
>> Looks good but I think one minor improvement could be to set the table
>> space of the toast entires to the same as the tablespace of the table to
>> reduce the amount of "SET default_tablespace". What do you think?
>
> Yes, you're right, some useless "SET default_tablespace" were added for
> each ALTER TABLE SET TOAST TABLESPACE statement. It's now fixed with
> this new patch. Thanks.

I am confused by your fix. Wouldn't cleaner fix be to use 
tbinfo->reltablespace rather than tbinfo->reltoasttablespace when 
calling ArchiveEntry()?

I tried the attached path and it seemed to work just fine.

-- 
Andreas Karlsson