Re: patch : Allow toast tables to be moved to a different tablespace

Julien Tachoires <julmon@gmail.com>

From: Julien Tachoires <julmon@gmail.com>

To: Andreas Karlsson <andreas@proxel.se>, Alex Shulgin <ash@commandprompt.com>

Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Jaime Casanova <jaime@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2015-03-19T15:55:10Z

Lists: pgsql-hackers

Attachments

set_toast_tablespace_v0.16.patch.gz (application/gzip) patch v0

On 18/03/2015 19:54, Andreas Karlsson wrote:
> On 03/17/2015 09:00 AM, Julien Tachoires wrote:
>> Here is a new version fixing this issue. I've added a new kind of TOC
>> entry for being able to handle pg_restore --no-tablespace case.
> 
> Looks good but I think one minor improvement could be to set the table 
> space of the toast entires to the same as the tablespace of the table to 
> reduce the amount of "SET default_tablespace". What do you think?

Yes, you're right, some useless "SET default_tablespace" were added for
each ALTER TABLE SET TOAST TABLESPACE statement. It's now fixed with
this new patch. Thanks.

--
Julien