Re: Convert sepgsql tests to TAP
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: tharakan@gmail.com, Peter Eisentraut <peter@eisentraut.org>,
pgsql-hackers <pgsql-hackers@postgresql.org>,
Joe Conway <mail@joeconway.com>, Andreas Karlsson <andreas@proxel.se>
Date: 2025-01-24T23:08:31Z
Lists: pgsql-hackers
I wrote: > Oh ... wait a second. After further code reading I see that > the BF client sets NO_TEMP_INSTALL if check_install_is_complete > succeeds. So evidently, that is successfully suppressing > "make install" on most animals, but not these two. How come? Got it: we can see on alligator that it installs (for instance) test_parser.so into /usr/bin/install -c -m 755 test_parser.so '/home/postgres/proj/build-farm-17/buildroot/HEAD/inst/lib/test_parser.so' but what check_install_is_complete is looking for is $tmp_loc = "$tmp_loc/$install_dir"; $bindir = "$tmp_loc/bin"; $libdir = "$tmp_loc/lib/postgresql"; ... my $res = ( (-d $tmp_loc) && (-f "$bindir/postgres" || -f "$bindir/postgres.exe") && (-f "$libdir/hstore$suffix") && (-f "$libdir/test_parser$suffix")); That is, check_install_is_complete expects to see test_parser.so under installdir/lib/postgresql/, but it's actually getting put into installdir/lib/ because "postgres" appears earlier in the path. So we're forcing a bunch of useless "make install"s, but that was never mission-critical until today. Unsurprisingly, lapwing is also running under /home/postgres/. Apparently no other BF animals are. regards, tom lane
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
sepgsql: update TAP test to use fat comma style
- cc2c9fa6960c 18.0 landed
-
Convert sepgsql tests to TAP
- aeb8ea361a0a 18.0 landed
-
meson: Fix sepgsql installation
- 155d6162e457 16.7 landed
- 24c5b73eb6ec 17.3 landed
- 02ed3c2bdcef 18.0 landed