Re: explain analyze rows=%.0f

Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>

From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>

To: Guillaume Lelarge <guillaume@lelarge.info>

Cc: Daniel Gustafsson <daniel@yesql.se>, Ibrar Ahmed <ibrar.ahmad@gmail.com>, "Gregory Stark (as CFM)" <stark.cfm@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, Peter Geoghegan <pg@bowt.ie>, vignesh C <vignesh21@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2025-01-11T11:10:47Z

Lists: pgsql-hackers

Attachments

v5-0001-Clarify-display-of-rows-and-loops-as-decimal-fraction.patch (text/x-patch) patch v5-0001

On 11.01.2025 12:15, Guillaume Lelarge wrote:
>
>
> Thanks for your patch, this looks like a very interesting feature that 
> I'd like to see in a future release.
>
> It did a quick run: patch OK, make OK, make install OK, but make check 
> fails quite a lot on partition_prune.sql.
>
> I guess it would need some work on partition_prune.sql tests and 
> perhaps also on the docs.
>
> Thanks again.
>
>
> -- 
> Guillaume.

Yes, certainly. I have fixed partition_prune.sql. In the documentation 
example for EXPLAIN ANALYZE where loops is greater than one, I updated 
how 'rows' and 'loops' values are displayed so they appear as decimal 
fractions with two digits after the decimal point.

I attached fixed patch.

Any suggestions?

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

Commits

EXPLAIN: Always use two fractional digits for row counts.
- 95dbd827f2ed 18.0 landed
Adjust EXPLAIN test case to filter out "Actual Rows" values.
- 44cbba9a7f51 18.0 cited
Allow EXPLAIN to indicate fractional rows.
- ddb17e387aa2 18.0 landed
Fix pgbench performance issue induced by commit af35fe501.
- fb056564ec5b 18.0 cited