Horton

Re: testclient.exe installed under MSVC

Jacob Champion <pchampion@vmware.com>

View thread View on postgr.es
From: Jacob Champion <pchampion@vmware.com>
To: "daniel@yesql.se" <daniel@yesql.se>, "michael@paquier.xyz" <michael@paquier.xyz>
Cc: "noah@leadboat.com" <noah@leadboat.com>, "pryzby@telsasoft.com" <pryzby@telsasoft.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2022-05-02T15:21:23Z
Lists: pgsql-hackers 
On Mon, 2022-05-02 at 15:14 +0200, Daniel Gustafsson wrote:
> Using a pg_ prefix
> makes them sound like actual useful tools though with (albeit small) risk for
> confusion?  Noah's suggestion of libpq_ is perhaps better: libpq_testclient.

+1

I also like Justin's idea of only installing the test executables when
asked to explicitly, but I don't know enough about our existing MSVC
conventions to have a strong opinion there.

Thanks,
--Jacob

Commits

  1. Add Windows file version information to libpq/test programs.

  2. Rename libpq test programs with libpq_ prefix

  3. Build libpq test programs under MSVC

  4. Enable SSL library detection via PQsslAttribute()