Re: [PATCH] Support % wildcard in extension upgrade filenames
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Regina Obe <r@pcorp.us>
Cc: pgsql-hackers@lists.postgresql.org, Sandro Santilli <strk@kbt.io>
Date: 2023-01-09T22:51:49Z
Lists: pgsql-hackers
I continue to think that this is a fundamentally bad idea. It creates all sorts of uncertainties about what is a valid update path and what is not. Restrictions like + Such wildcard update + scripts will only be used when no explicit path is found from + old to target version. are just band-aids to try to cover up the worst problems. Have you considered the idea of instead inventing a "\include" facility for extension scripts? Then, if you want to use one-monster-script to handle different upgrade cases, you still need one script file for each supported upgrade step, but those can be one-liners including the common script file. Plus, such a facility could be of use to people who want intermediate factorization solutions (that is, some sharing of code without buying all the way into one-monster-script). regards, tom lane