Horton

Re: pgsql: Prevent invalidation of newly synced replication slots.

Greg Burd <greg@burd.me>

View thread View on postgr.es
From: Greg Burd <greg@burd.me>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Amit Kapila <akapila@postgresql.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-01-27T16:53:38Z
Lists: pgsql-hackers 
> On Jan 27, 2026, at 10:49 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> I wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> This commit has broken CI for me.
> 
>> Hmm, I wonder why the buildfarm seems fine with it ... I'm prepared
>> to believe a Windows-only problem, but at least hamerkop has run
>> since 851f664.
> 
> D'oh: hamerkop doesn't run any TAP tests, let alone ones that require
> --enable-injection-points.  So that success proves nothing.
> 
> Our other Windows animals (drongo, fairywren, unicorn) seem to be
> configured with -Dtap_tests=enabled, but nothing about injection
> points, so they will also skip 046_checkpoint_logical_slot.
> Seems like a bit of a blind spot in the buildfarm.
> 
> regards, tom lane
> 


I'll see if I can update unicorn today to enable injection points to add some coverage on Win11/ARM64/MSVC.  No promises that will be diagnostic at all, but it seems like a good idea.


-Dinjection_points=true


-greg

Commits

  1. Fix CI failure introduced in commit 851f6649cc.

  2. Prevent invalidation of newly synced replication slots.

  3. Prevent invalidation of newly created replication slots.