Horton

Re: [16+] subscription can end up in inconsistent state

Jeff Davis <pgsql@j-davis.com>

View thread View on postgr.es
From: Jeff Davis <pgsql@j-davis.com>
To: vignesh C <vignesh21@gmail.com>, Peter Smith <smithpb2250@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, pgsql-bugs@postgresql.org
Date: 2024-01-12T21:55:28Z
Lists: pgsql-bugs 
On Mon, 2023-11-27 at 10:26 +0530, vignesh C wrote:
> The patch was not applying on HEAD because of recent commits, the
> attached v6 version patch is rebased on top of HEAD.

Thank you, committed with minor modifications.

I decided to do:

   libpqrcv_check_conninfo(conninfo, must_use_password);

rather than:

   if (must_use_password)                                             
      libpqrcv_check_conninfo(conninfo, true);

because if there's some parsing error then we wouldn't like it to be
conditional on must_use_password. Of course, there should not be any
parsing error because it was already validated at DDL time, but in case
there's another way to get into an inconsistent state, we might as well
re-validate here.

Regards,
	Jeff Davis

Commits

  1. Fix buildfarm error from commit 5c31669058.

  2. Re-validate connection string in libpqrcv_connect().