Re: Non-reproducible valgrind failure on HEAD
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-05-09T22:17:36Z
Lists: pgsql-hackers
Attachments
- improve-USE_VALGRIND-comment.patch (text/x-diff) patch
Andres Freund <andres@anarazel.de> writes: > On 2021-05-09 17:12:14 -0400, Tom Lane wrote: >> (I wonder if we shouldn't adjust the comments in pg_config_manual.h, >> though, as they certainly leave the impression that USE_VALGRIND >> isn't essential.) > That'd make sense to me. If we found a better way to deal with the > sinval thing it'd be good too - but I am not seeing anything convincing, > and I looked a couple times over the years... Yeah, it's actually somewhat amazing that we get useful results at all around shared-memory accesses. Proposed comment patch attached. regards, tom lane
Commits
-
Improve comments about USE_VALGRIND in pg_config_manual.h.
- 8dc3d68cbe67 14.0 landed