Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

Alexey Kondratov <a.kondratov@postgrespro.ru>

From: Alexey Kondratov <a.kondratov@postgrespro.ru>

To: Andrey Borodin <x4mmm@yandex-team.ru>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, Dmitry Dolgov <9erthalion6@gmail.com>, Michael Paquier <michael@paquier.xyz>, Alvaro Herrera <alvherre@2ndquadrant.com>, vladimirlesk@yandex-team.ru, dsarafan@yandex-team.ru

Date: 2019-02-08T15:30:18Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Move frontend-side archive APIs from src/common/ to src/fe_utils/
- 8d8b89266ca0 13.0 landed
- a3b2bf1fe7ce 14.0 landed
Add -c/--restore-target-wal to pg_rewind
- a7e8ece41cf7 13.0 landed
Move routine definitions of xlogarchive.c to a new header file
- 616ae3d2b056 13.0 landed
Move routine building restore_command to src/common/
- e09ad07b21a2 13.0 landed
Integrate recovery.conf into postgresql.conf
- 2dedf4d9a899 12.0 cited

Attachments

0001-pg_rewind-options-to-use-restore_command-v2.2.patch (text/x-patch)

On 21.01.2019 23:50, a.kondratov@postgrespro.ru wrote:
> Thank you for the review! I have updated the patch according to your
> comments and remarks. Please, find new version attached.

During the self-reviewing of the code and tests, I discovered some 
problems with build on Windows. New version of the patch is attached and 
it fixes this issue as well as includes some minor code revisions.

Regards

-- 
Alexey Kondratov

Postgres Professional https://www.postgrespro.com
Russian Postgres Company