Re: Reduce TupleHashEntryData struct size by half
Jeff Davis <pgsql@j-davis.com>
From: Jeff Davis <pgsql@j-davis.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>, Heikki Linnakangas
<hlinnaka@iki.fi>, pgsql-hackers@postgresql.org
Date: 2025-06-13T17:08:43Z
Lists: pgsql-hackers
On Fri, 2025-06-13 at 16:33 +1000, Peter Smith wrote: > I was looking at this code recently and noticed the following. > Although the commit [1] removed the ->additional field, some function > comments were not updated to reflect this, so now they seemed a bit > stale. Thank you! Fixed. Regards, Jeff Davis
Commits
-
Comment fixups from 626df47ad9.
- a0c7b765372d 18.0 landed
-
Remove 'additional' pointer from TupleHashEntryData.
- 626df47ad9db 18.0 cited
-
Add ExecCopySlotMinimalTupleExtra().
- a0942f441ed6 18.0 landed
-
Create accessor functions for TupleHashEntry.
- 4d143509cbfa 18.0 landed
-
TupleHashTable: store additional data along with tuple.
- e0ece2a981ee 18.0 landed
-
ExecInitAgg: update aggstate->numaggs and ->numtrans earlier.
- 3f482940dbcb 18.0 landed
-
nodeSetOp.c: missing additionalsize for BuildTupleHashTable().
- 32ddfaffd149 18.0 landed
-
Remove unused TupleHashTableData->entrysize.
- 8a96faedc408 18.0 landed
-
Add missing typedefs.list entry for AggStatePerGroupData.
- 834c9e807cf1 18.0 landed