Re: parser handling of large object OIDs

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2010-06-10T02:26:12Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Jun 9, 2010 at 5:02 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> I believe that the comment code is probably right, because I think
>> IConst can only handle values < 2^31, whereas OIDs can be as large as
>> 2^32-1.

> I investigated this a little more and the above analysis turns out to
> be correct.  ALTER LARGE OBJECT OWNER and GRANT ... ON LARGE OBJECT
> don't work for large objects outside the range of a signed integer.

Yup.

> Session demonstrating the problem and proposed patch attached.

This patch seems extremely grotty, though.  Surely that's not the way we
were doing it in the comment code?

			regards, tom lane