Re: Supporting Windows SChannel as OpenSSL replacement

Heikki Linnakangas <hlinnakangas@vmware.com>

From: Heikki Linnakangas <hlinnakangas@vmware.com>

To: Andreas Karlsson <andreas@proxel.se>, Jeff Janes <jeff.janes@gmail.com>

Cc: Martijn van Oosterhout <kleptog@svana.org>, Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2014-08-01T17:40:25Z

Lists: pgsql-hackers

Attachments

0001-Invent-a-new-internal-API-for-interfacing-with-SSL-2.patch (text/x-diff) patch 0001

On 06/27/2014 02:26 AM, Andreas Karlsson wrote:
> On 06/24/2014 03:20 AM, Jeff Janes wrote:
>> I've tried your 0001 patch, reflecting this refactoring, on Linux and it
>> caused 'make check' to hang at 'starting postmaster'.
>
> I found the bug in the code, and I have attached the a patch which you
> can apply on top of the patch. The regression tests pass now on my
> Debian machine.

Ah, thanks!

> One thing I noticed when trying to find the bug is that be-secure.c
> still includes some OpenSSL headers. Those should be removed since they
> have already been moved to be-secure-openssl.c.

Removed.

Here's a new version of the patch, rebased over master and those two 
things fixed.

- Heikki