Re: WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

Adrian Vondendriesch <adrian.vondendriesch@credativ.de>

From: Adrian Vondendriesch <adrian.vondendriesch@credativ.de>

To: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org

Date: 2014-04-01T15:06:08Z

Lists: pgsql-hackers

Attachments

libpq_conninfo_array_parse_empty_string_v1.patch (text/x-patch) patch v1

Am 01.04.2014 16:32, schrieb Tom Lane:
> Adrian Vondendriesch <adrian.vondendriesch@credativ.de> writes:
>> I patched the function conninfo_array_parse() which is used by
>> PQconnectStartParams to behave like PQsetdbLogin. The patch also
>> contains a document patch which clarify "unspecified" parameters. 
> 
> I see no documentation update here.  I'm also fairly concerned about the
> implication that no connection parameter, now or in future, can ever have
> an empty string as the correct value.

If we want to preserve the possibility to except an empty string as
correct value, then pgbench should initialise some variables with
NULL instead of empty string.

Moreover it should be documented that "unspecified" means NULL and not
empty string, like in PQsetdbLogin.

However, attached you will find the whole patch, including documentation.

Kind Regards

	- Adrian