Re: New parameter RollbackError to control rollback behavior on error

Hi Michael,

Isn't it an ODBC issue?

regards,
Hiroshi Inoue

(2014/03/26 15:39), Michael Paquier wrote:
> Hi all,
>
> The behavior of rollback when an error occurs on an handle is
> controlled by extending Protocol with "$PROTNUM-[0|1|2]" where:
> - 0 = let the application handle rollbacks
> - 1 = rollback whole transaction when an error occurs
> - 2 = rollback only statement that failed
> Using such an extension is somewhat awkward as a single string is used
> for two settings... The proposed attached patch adds a new parameter
> called RollbackError that allows to control the behavior of rollback
> on error with a different parameter.
>
> For backward-compatibility purposes, this patch does not break the old
> grammar of Protocol: it just gives the priority to RollbackError if
> both Protocol and RollbackError are set for a connection. Regression
> tests to test RollbackError and combinations of RollbackError/Protocol
> are added in the patch in the existing test error-rollback (which has
> needed some refactoring, older tests are not impacted). Docs are
> included as well.
>
> I thought first about including that in my cleanup work for 9.4, but
> as this actually does not break the driver it may be worth adding it
> directly to master, explaining the patch attached here. Comments
> welcome. Note that if there are objections I do not mind adding that
> for the work that would be merged later to 9.4 builds.
>
> Regards,