Horton

Re: libpq: Remove redundant null pointer checks before free()

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-06-17T19:03:23Z
Lists: pgsql-hackers 
On 17.06.22 05:25, Michael Paquier wrote:
> On Thu, Jun 16, 2022 at 10:07:33PM +0200, Peter Eisentraut wrote:
>> calls, where the "if" part is unnecessary.  This is of course pretty
>> harmless, but some functions like scram_free() and freePGconn() have become
>> so bulky that it becomes annoying.  So while I was doing some work in that
>> area I undertook to simplify this.
> Seems fine.  Would some of the buildfarm dinosaurs hiccup on that?
> gaur is one that comes into mind.

I'm pretty sure PostgreSQL code already depends on this behavior anyway. 
  The code just isn't consistent about it.

Commits

  1. Remove redundant null pointer checks before PQclear and PQconninfoFree

  2. Remove redundant null pointer checks before free()

  3. Remove redundant null pointer checks before pg_free()