Re: Misleading comment in pg_upgrade.c

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-12-05T22:45:09Z
Lists: pgsql-hackers
> On 5 Dec 2019, at 10:17, Julien Rouhaud <rjuju123@gmail.com> wrote:

> While reading pg_upgrade code to restore the objects on the new
> cluster, I noticed that 5b570d771b8 didn't adjust the database name in
> the comments explaining the requirements for an extra "--clean" for
> template1 and postgres databases.  While it's true that both databases
> will already exist, I found it confusing to mention both names when
> only one is processed for each code path.

Agreed, I think this reads better.

cheers ./daniel




Commits

  1. Improve some comments in pg_upgrade.c