Horton

Re: generate_series for timestamptz and time zone problem

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Andreas 'ads' Scherbaum" <ads@pgug.de>
Cc: Gurjeet Singh <gurjeet@singh.im>, Przemysław Sztoch <przemyslaw@sztoch.pl>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2023-03-18T18:18:04Z
Lists: pgsql-hackers 
Pushed v7 after making a bunch of cosmetic changes.  One gripe
I had was that rearranging the logic in timestamptz_pl_interval[_internal]
made it nearly impossible to see what functional changes you'd made
there, while not really buying anything in return.  I undid that to
make the diff readable.

I did not push the fmgr.h changes.  Maybe that is worthwhile (although
I'd vote against it), but it certainly does not belong in a localized
feature patch.

			regards, tom lane

Commits

  1. Add functions to do timestamptz arithmetic in a non-default timezone.

  2. Refactor datetime functions' timezone lookup code to reduce duplication.

  3. Fix volatility marking of timestamptz_trunc_zone.