Re: [18] Unintentional behavior change in commit e9931bfb75

Jeff Davis <pgsql@j-davis.com>

View thread View on postgr.es

From: Jeff Davis <pgsql@j-davis.com>

To: Noah Misch <noah@leadboat.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org

Date: 2025-04-15T23:08:55Z

Lists: pgsql-hackers

Attachments

v2-0001-Improve-comment-in-regc_pg_locale.c.patch (text/x-patch) patch v2-0001
v2-0002-Another-unintentional-behavior-change-in-commit-e.patch (text/x-patch) patch v2-0002
v2-0003-alternative-approach.patch (text/x-patch) patch v2-0003

On Mon, 2025-04-14 at 13:44 -0700, Noah Misch wrote:
> v18 regc_pg_locale.c uses only the locale_t-extended forms, and it
> aims not to
> depend on LC_CTYPE.  v17 used both tolower() and tolower_l(), but v18
> uses the
> latter only.

Fixed in v2-0001 by rewording the comment slightly.

> 
> However, I think v17's
> concept of separate PG_REGEX_ symbols for the default-locale case is
> still the
> right thing for v18.  In other words, this code should change to look
> more
> like v17, with the removal of non-locale_t calls being the main
> change.

I tried that in v2-0003, but I think it ended up worse. Most
pg_wc_xyz() functions don't care if it's the default collation or not,
so there are a lot of duplicate cases.

The previous approach is still there as v2-0002.

Regrads,
	Jeff Davis

Commits

Another unintentional behavior change in commit e9931bfb75.
- 2e5353be2534 18.0 landed
Improve comment in regc_pg_locale.c.
- b107744ce737 18.0 landed
Fix unintentional behavior change in commit e9931bfb75.
- e3fa2b037c6f 18.0 landed
Remove support for null pg_locale_t most places.
- e9931bfb7515 18.0 cited
Fix up handling of C/POSIX collations.
- 176d5bae1d63 9.1.0 cited