Re: proposal - function string_to_table
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>,
"movead.li@highgo.ca" <movead.li@highgo.ca>,
Justin Pryzby <pryzby@telsasoft.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-09-02T22:30:12Z
Lists: pgsql-hackers
Pavel Stehule <pavel.stehule@gmail.com> writes: > [ string_to_table-20200825.patch ] I reviewed this, whacked it around a little, and pushed it. Possibly the most controversial thing I did was to move the existing documentation entry for string_to_array() into the string-functions table. I did not like it one bit that the patch was documenting string_to_table() far away from string_to_array(), and on reflection I concluded that you'd picked the right place and the issue here is that string_to_array() was in the wrong place. Also, I pared the proposed regression tests a great deal, ending up with something that matches the existing tests for string_to_array(). The proposed tests seemed mighty duplicative, and they even contained syntax errors, so I didn't believe that they were carefully considered. regards, tom lane
Commits
-
Add string_to_table() function.
- 66f163068030 14.0 landed