Horton

Re: Review: ECPG FETCH readahead

Böszörményi Zoltán <zboszor@pr.hu>

View thread
From: Boszormenyi Zoltan <zboszor@pr.hu>
To: Antonin Houska <antonin.houska@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, PG Hackers <pgsql-hackers@postgresql.org>, Michael Meskes <meskes@postgresql.org>, Noah Misch <noah@leadboat.com>, Peter Eisentraut <peter_e@gmx.net>, Robert Haas <robertmhaas@gmail.com>, Heikki Linnakangas <hlinnakangas@vmware.com>, Bruce Momjian <bruce@momjian.us>, Hans-Jürgen Schönig <hs@cybertec.at>
Date: 2014-04-24T13:19:48Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix some "translator:" comments mangled by pgindent

  2. Make sure float4in/float8in accept all standard spellings of "infinity".

2014-04-24 14:50 keltezéssel, Michael Meskes írta:
> Thanks an awful lot Antonin.
>
>> Committer availability might well be the issue, but missing review
>> probably too.
> Yes, you're right. If my taks is mostly one last glance and a commit I will make time for that.
>
>> Whether this review is enough to move the patch to "ready for committer"
>> - I tend to let the next CFM decide. (I don't find it productive to
>> ignite another round of discussion about kinds of reviews - already saw
>> some.)
> I saw some remarks in your review that Zoltan wants to address. Once I got the
> updated version I'll have a look at it.
>
> Zoltan, could you send a new version by end of day tomorrow? I'll be sitting on
> a plane for a longer time again on Saturday. :)

I will try to.

Thanks in advance,
Zoltán

>
> Michael