Horton

Re: Review: ECPG FETCH readahead

Antonin Houska <antonin.houska@gmail.com>

View thread
From: Antonin Houska <antonin.houska@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Boszormenyi Zoltan <zboszor@pr.hu>, PG Hackers <pgsql-hackers@postgresql.org>, Michael Meskes <meskes@postgresql.org>, Noah Misch <noah@leadboat.com>, Peter Eisentraut <peter_e@gmx.net>, Robert Haas <robertmhaas@gmail.com>, Heikki Linnakangas <hlinnakangas@vmware.com>, Bruce Momjian <bruce@momjian.us>, Hans-Jürgen Schönig <hs@cybertec.at>
Date: 2014-04-23T22:15:41Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix some "translator:" comments mangled by pgindent

  2. Make sure float4in/float8in accept all standard spellings of "infinity".

On 04/23/2014 05:24 PM, Alvaro Herrera wrote:
> Antonin Houska wrote:
>> I haven't been too familiar with the ECPG internals so far but tried to
>> do my best.
> 
> I'm afraid we're stuck on this patch until Michael has time to review
> it, or some other committer wants to acquire maintainership rights in
> the ECPG code.
> 

Committer availability might well be the issue, but missing review
probably too.

Whether this review is enough to move the patch to "ready for committer"
- I tend to let the next CFM decide. (I don't find it productive to
ignite another round of discussion about kinds of reviews - already saw
some.)

// Tony