Horton

Re: narwhal and PGDLLIMPORT

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Craig Ringer <craig@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "Inoue, Hiroshi" <inoue@tpf.co.jp>, Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@2ndquadrant.com>, Amit Kapila <amit.kapila16@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2014-02-12T01:33:20Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. MinGW: Link with shell32.dll instead of shfolder.dll.

  2. Centralize getopt-related declarations in a new header file pg_getopt.h.

  3. Get rid of use of dlltool in Mingw builds.

  4. Export a few more symbols required for test_shm_mq module.

  5. Export set_latch_on_sigusr1 symbol for Windows.

  6. Use SHGetFolderPath instead of SHGetSpecialFolderPath to find the

On 02/11/2014 08:04 PM, Craig Ringer wrote:
> On 02/12/2014 08:30 AM, Tom Lane wrote:
>> Craig Ringer <craig@2ndquadrant.com> writes:
>>> On 02/12/2014 07:22 AM, Tom Lane wrote:
>>>> So the early returns from currawong are interesting:
>>> Great, that's what I was hoping to see - proper errors where we've
>>> omitted things, not silent miscompilation.
>> Well, before you get too optimistic about that benighted platform ...
>> mastodon just reported in on this patch, and it's showing a *different*
>> set of unresolved symbols than currawong is.  None of them are a
>> surprise exactly, but nonetheless, why didn't currawong find the
>> postgres_fdw issues?
>>
>> It still seems there's something unexplained here.
> Looks like currawong doesn't build postgres_fdw.
>
>


It sure used to: 
<http://www.pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=currawong&dt=2014-02-03%2005%3A30%3A00&stg=make>

cheers

andrew