Horton

Re: narwhal and PGDLLIMPORT

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Marco Atzeri <marco.atzeri@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2014-02-09T13:10:45Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. MinGW: Link with shell32.dll instead of shfolder.dll.

  2. Centralize getopt-related declarations in a new header file pg_getopt.h.

  3. Get rid of use of dlltool in Mingw builds.

  4. Export a few more symbols required for test_shm_mq module.

  5. Export set_latch_on_sigusr1 symbol for Windows.

  6. Use SHGetFolderPath instead of SHGetSpecialFolderPath to find the

On 02/09/2014 01:12 AM, Marco Atzeri wrote:
>
>
> On 09/02/2014 00:06, Andrew Dunstan wrote:
>>
>> On 02/08/2014 05:34 PM, Tom Lane wrote:
>>> Hiroshi Inoue <inoue@tpf.co.jp> writes:
>>>> Though I'm not a MINGW expert at all, I know dllwrap is a deprecated
>>>> tool and dlltool is almost a deprecated tool. Cygwin port is removing
>>>> the use of dllwrap and dlltool now. Isn't it better for MINGW port to
>>>> follow it?
>>> Only way to make that happen is to prepare and test a patch ...
>>
>> Yeah. Incidentally, we didn't quite get rid of dlltool for Cygwin. We
>> did get rid of dllwrap. But I agree this is worth trying for Mingw.
>>
>
> we should have get rid of dlltool on cygwin.
> At least it is not used on my build
>
> Regards
> Marco
>
>
>


The send in a patch. The patch you sent in previously did not totally 
remove it IIRC.

cheers

andrew