Horton

Re: Review: ECPG infrastructure changes part 1, was: Re: ECPG fixes

Boszormenyi Zoltan <zb@cybertec.at>

View thread
From: Boszormenyi Zoltan <zb@cybertec.at>
To: Antonin Houska <antonin.houska@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Michael Meskes <meskes@postgresql.org>
Cc: Noah Misch <noah@leadboat.com>, Peter Eisentraut <peter_e@gmx.net>, Robert Haas <robertmhaas@gmail.com>, PG Hackers <pgsql-hackers@postgresql.org>, Heikki Linnakangas <hlinnakangas@vmware.com>, Bruce Momjian <bruce@momjian.us>, Hans-Jürgen Schönig <hs@cybertec.at>
Date: 2013-12-06T13:01:42Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix some "translator:" comments mangled by pgindent

  2. Make sure float4in/float8in accept all standard spellings of "infinity".

Attachments

2013-12-04 14:51 keltezéssel, Boszormenyi Zoltan írta:
> 2013-12-03 16:48 keltezéssel, Antonin Houska írta:
>
>> Tests - 23.patch
>> ----------------
>>
>> src/interfaces/ecpg/test/sql/cursorsubxact.pgc
>>
>>
>>          /*
>>           * Test the implicit RELEASE SAVEPOINT if a SAVEPOINT
>>           * is used with an already existing name.
>>           */
>>
>> Shouldn't it be "... if a CURSOR is used with an already existing
>> name?". Or just "... implicit RELEASE SAVEPOINT after an error"?
>> I'd also appreciate a comment where exactly the savepoint is
>> (implicitly) released.
>
> I have already answered this in my previous answer.

And I was wrong in that. The comments in the test were rearranged
a little and the fact in the above comment is now actually tested.

Some harmless unused variables were also removed and an
uninitialized variable usage was fixed. Because of these and the above
changes a lot of patches need to be rebased.

All patches are attached again for completeness.

Best regards,
Zoltán Böszörményi

-- 
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
      http://www.postgresql.at/