Re: [PATCH] Expose port->authn_id to extensions and triggers

Hi,

On 8/14/22 11:57 AM, Michael Paquier wrote:
> On Fri, Aug 12, 2022 at 03:34:04PM +0200, Drouvot, Bertrand wrote:
>> 3)
>>
>> +SerializeClientConnectionInfo(Size maxsize, char *start_address)
>> +{
>> +       /*
>> +        * First byte is an indication of whether or not authn_id has been
>> set to
>> +        * non-NULL, to differentiate that case from the empty string.
>> +        */
>>
>> is authn_id being an empty string possible?
> I don't recall that this can be the case yet, but we cannot discard
> it.
Fair point.
>    One thing was itching me about the serialization and
> deserialization logic though: could it be more readable if we used an
> intermediate structure to store the length of the serialized strings?
> We use this approach in other areas, like for the snapshot data in
> snapmgr.c.  This would handle the case of an empty and NULL string, by
> storing -1 as length for NULL and >= 0 for the string length if there
> is something set, while making the addition of more fields a
> no-brainer.

I think that's a good idea and I think that would be more readable (as 
compare to storing a "hint" in the first byte).

Regards,

-- 
Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com