Re: JSON/SQL: jsonpath: incomprehensible error message
Erik Rijkers <er@xs4all.nl>
From: Erik Rijkers <er@xs4all.nl>
To: Amit Kapila <amit.kapila16@gmail.com>,
Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-06-29T13:28:02Z
Lists: pgsql-hackers
Op 29-06-2022 om 15:00 schreef Amit Kapila:
> On Mon, Jun 27, 2022 at 8:46 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>>
>> On 2022-06-26 Su 11:44, Erik Rijkers wrote:
>>> JSON/SQL jsonpath
>>>
>>> For example, a jsonpath string with deliberate typo 'like_regexp'
>>> (instead of 'like_regex'):
>>>
>>> select js
>>> from (values (jsonb '{}')) as f(js)
>>> where js @? '$ ? (@ like_regexp "^xxx")';
>>>
>>> ERROR: syntax error, unexpected IDENT_P at or near " " of jsonpath input
>>> LINE 1: ...s from (values (jsonb '{}')) as f(js) where js @? '$ ? (@
>>> li...
>>>
>>> Both 'IDENT_P' and 'at or near " "' seem pretty useless.
>>>
> removing this. One thing that is not clear to me is why OP sees an
> acceptable message (ERROR: syntax error, unexpected invalid token at
> or near "=" of jsonpath input) for a similar query in 14?
To mention that was perhaps unwise of me because The IDENT_P (or more
generally, *_P) messages can be provoked on 14 too. I just thought
'invalid token' might be a better message because 'token' gives a more
direct association with 'errors during parsing' which I assume is the
case here.
IDENT_P or ANY_P convey exactly nothing.
Erik
Commits
-
Remove %error-verbose directive from jsonpath parser
- 7d9bf589ba84 15.0 landed
- 2cf875a4b58d 12.12 landed
- 03cefe81484d 13.8 landed
- 7fd43684fc9e 14.5 landed
- 89a39d4a4da0 16.0 landed
-
Partial implementation of SQL/JSON path language
- 72b6460336e8 12.0 cited